chore(Android): update spotless & ktlint #2053
Conversation
kkafar
force-pushed
the
@kkafar/android-linter
branch
from
c03dac9 to
ad6b12d
Compare
|
Yeah, I was waiting for this being released & it happened with release of ktlint 1.2.0 few hours ago. -> I bumped it, let's see whether it will work now. |
tboba
force-pushed
the
@kkafar/android-linter
branch
from
16f71a6 to
4c53cd3
Compare
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.4-all.zip |
There was a problem hiding this comment.
This change is because of the too old version of Gradle that doesn't support newest Java versions. I've decided to update it in occasion.
|
Because of the new version of ktlint, I see that some of new rules have been introduced that changes the way how we're writing the code. @kkafar should we disable some of them, or leave the changes as they are? What do you think? |
|
I'll get back to this PR tomorrow, resolve conflicts. If some rules changed we should just reformat the whole kotlin codebase according to new rules. |
|
@kkafar just a small polite bump as a reminder 😄 |
|
Thank you! |
|
I'll close the PR and open another one, as there too many conflicts to resolve right now. |
Description
Encountered some errors (seems they were looking for old CMake version (3.10.2)) & decided to bump these deps.
Changes
Ktlint: 0.43 -> 1.1.1
spotless 6.11 -> 6.22
Checklist